Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -o shorthand for --output flag to skaffold render #5526

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

nkubala
Copy link
Contributor

@nkubala nkubala commented Mar 10, 2021

Description

This change adds a shorthand flag, -o, for the existing --output flag to skaffold render. All other uses of --output across our other commands have this shorthand, so this one should have it too.

User facing changes (remove if N/A)

@nkubala nkubala requested a review from a team as a code owner March 10, 2021 21:37
@google-cla google-cla bot added the cla: yes label Mar 10, 2021
@codecov
Copy link

codecov bot commented Mar 10, 2021

Codecov Report

Merging #5526 (5927286) into master (3160270) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5526   +/-   ##
=======================================
  Coverage   71.32%   71.32%           
=======================================
  Files         400      400           
  Lines       14831    14831           
=======================================
  Hits        10578    10578           
  Misses       3475     3475           
  Partials      778      778           
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/render.go 46.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3160270...5927286. Read the comment docs.

@nkubala nkubala merged commit adf31ae into GoogleContainerTools:master Mar 12, 2021
@nkubala nkubala deleted the render-shorthand branch March 12, 2021 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants